Terminology
- Main Branch - Must be named "main", must always have passing tests, and is not guaranteed to always work in production environments.
- Change Branches - Any branch that introduces changes like a new feature, a bugfix, etc.
- Source Branch - The branch that a change branch was created from. New changes in the source branch should be incorporated into the change branch via rebasing.
- Merge Target - A branch that is the intended merge target for a change branch. Typically the merge target branch will be the same as the source branch.
- Pull Request - A means of requesting that a change branch is merged in to its merge target, allowing others to review, discuss and approve the changes.
- Release - May be considered safe to use in production environments. Is effectively just a git tag named after the version of the release.
- Release Branches - Used both for short-term preparations of a release, and for long-term maintenance of older versions.
Specification
The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119.
- TL;DR
- Do not break the main branch.
- A release is a git tag.
- The Main Branch
- A branch named "main" MUST exist and it MUST be referred to as the "main branch".
- The main branch MUST always be in a non-broken state with its test suite passing.
- The main branch is not guaranteed to always work in production environments. Despite test suites passing it may at times contain unfinished work. Only releases may be considered safe for production use.
- The main branch SHOULD always be in a "as near as possibly ready for release/production" state to reduce any friction with creating a new release.
- Change Branches
- Each change (feature, bugfix, etc.) MUST be performed on separate branches that SHOULD be referred to as "change branches".
- All change branches MUST have descriptive names.
- It is RECOMMENDED that you commit often locally, and that you try and keep the commits reasonably structured to avoid a messy and confusing git history.
- You SHOULD regularly push your work to the same named branch on the remote server.
- You SHOULD create separate change branches for each distinctly different change. You SHOULD NOT include multiple unrelated changes into a single change branch.
- When a change branch is created, the branch that it is created from SHOULD be referred to as the "source branch". Each change branch also needs a designated "merge target" branch, typically this will be the same as the source branch.
- Change branches MUST be regularly updated with any changes from their source branch. This MUST be done by rebasing the change branch on top of the source branch.
- After updating a change branch from its source branch you MUST push the change branch to the remote server. Due to the nature of rebasing, you will be required to do a force push, and you MUST use the "--force-with-lease" git push option when doing so instead of the regular "--force".
- If there is a truly valid technical reason to not use rebase when updating change branches, then you MAY update change branches via merge instead of rebase. The decision to use merge MUST only be taken after all possible options to use rebase have been tried and failed. People not understanding how to use rebase is NOT a valid reason to use merge. If you do decide to use merge instead of rebase, you MUST NOT use a mixture of both methods.
- Pull Requests
- To merge a change branch into its merge target, you MUST open a "pull request" (or equivalent).
- The purpose of a pull request is to allow others to review your changes and give feedback. You can then fix any issues, complaints, and more that might arise, and then let people review again.
- Before creating a pull request, it is RECOMMENDED that you consider the state of your change branch's commit history. If it is messy and confusing, it might be a good idea to rebase your branch with "git rebase -i" to present a cleaner and easier to follow commit history for your reviewers.
- A pull request MUST only be merged when the change branch is up-to-date with its source branch, the test suite and other CI checks are passing, and you and others are happy with the changes. This is especially important if the merge target is the main branch.
- To get feedback, help, or generally just discuss a change branch with others, it is RECOMMENDED you create a draft pull request and discuss the changes with others there. This leaves a clear and visible history of how, when, and why the code looks and behaves the way it does.
- Git Best Practices
- It is RECOMMENDED that all commit messages follow the Conventional Commits specification (https://www.conventionalcommits.org/). This provides a structured format that integrates well with Semantic Versioning, and enables automated changelog generation. At minimum, commit messages SHOULD follow the Commit Guidelines from the official git documentation: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines
- You SHOULD always use "--force-with-lease" when doing a force push. The regular "--force" option is dangerous and destructive. More information: https://www.codestudy.net/blog/git-push-force-with-lease-vs-force/
- You SHOULD understand and be comfortable with rebasing: https://git-scm.com/book/en/v2/Git-Branching-Rebasing
- It is RECOMMENDED that you always do "git pull --rebase" instead of "git pull" to avoid unnecessary merge commits. You can make this the default behavior of "git pull" with "git config --global pull.rebase true".
- When using Conventional Commits, it is RECOMMENDED to use tooling to automate version bumping and generate changelogs from commit messages. This pairs well with the release process and ensures changelogs are consistent and complete.
- Versioning
- A "version string" is a typically mostly numeric string that identifies a specific version of a project. The version string itself MUST NOT have a "v" prefix, but the version string can be displayed with a "v" prefix.
- The source of truth for a project's version MUST be a git tag with a name based on the version string. This kind of tag MUST be referred to as a "release tag".
- It is OPTIONAL, but RECOMMENDED to also keep the version string hard-coded somewhere in the project code-base.
- If you hard-code the version string into the code-base, it is RECOMMENDED that you do so in a file called "VERSION" located in the root of the project. But be mindful of the conventions of your programming language and community when choosing if, where and how to hard-code the version string.
- If you are using a "VERSION" file in the root of the project, this file MUST only contain the exact version string, meaning it MUST NOT have a "v" prefix. For example, "v2.11.4" is bad, and "2.11.4" is good.
- It is OPTIONAL, but RECOMMENDED that the version string follows Semantic Versioning (http://semver.org/).
- Releases
- To create a new release, you MUST create a git tag named as the exact version string of the release. This kind of tag MUST be referred to as a "release tag".
- The release tag name can OPTIONALLY be prefixed with "v". For example, the tag name can be either "2.11.4" or "v2.11.4". Note that this "v" prefix is only for the tag name itself, the version string (as defined in section 6.1) MUST NOT have a "v" prefix.
- If the version string is hard-coded into the code-base, you MUST create a "version bump" commit which changes the hard-coded version string of the project.
- When using version bump commits, the release tag MUST be placed on the version bump commit, unless using a release pull request.
- It is OPTIONAL to use a "release pull request" to propose a release. A release pull request contains the version bump commit and any release-related changes (changelog updates, etc.). When using release pull requests, the release tag SHOULD be placed on the resulting merge commit.
- If you are not using a release branch, then the release tag, and if relevant the version bump commit, MUST be created directly on the main branch.
- If you are using Conventional Commits, the version bump commit MUST also follow the format. For example, "chore(release): 2.11.4". Otherwise, a simple "Bump version to 2.11.4" format is acceptable.
- Release tags SHOULD be lightweight tags unless you need features that annotated tags provide. Annotated tags allow you to include changelog information in the tag itself, GPG sign the tag, or include additional metadata like the tagger's name and email.
- If you use annotated release tags, the first line of the annotation SHOULD read "Release VERSION". For example for version "2.11.4" the first line of the tag annotation SHOULD read "Release 2.11.4". The second line MUST be blank, and the changelog SHOULD start on the third line.
- It is OPTIONAL, but RECOMMENDED for high-security projects, to GPG sign release tags. This provides cryptographic verification that the release was created by a trusted party.
- Short-Term Release Branches
- Any branch that has a name starting with "release-" SHOULD be referred to as a "release branch".
- Any release branch which has a name ending with a specific version string, MUST be referred to as a "short-term release branch".
- Use of short-term release branches are OPTIONAL, and intended to be used to create a specific versioned release.
- A short-term release branch is RECOMMENDED if there is a lengthy release verification process to avoid a code freeze on the main branch.
- Short-term release branches MUST have a name of "release-VERSION". For example for version "2.11.4" the release branch name MUST be "release-2.11.4".
- When using a short-term release branch to create a release, the version bump commit if used, MUST be created on the short-term release branch. The release tag MUST be placed on the version bump commit, or on the merge commit when using a release pull request to merge the release branch.
- Only very minor changes SHOULD be performed on a short-term release branch directly. Any larger changes SHOULD be done in the main branch, and SHOULD be pulled into the release branch by rebasing it on top of the main branch the same way a change branch pulls in updates from its source branch.
- After a release tag has been created, the release branch MUST be merged back into its source branch and then deleted. Typically the source branch will be the main branch.
- Long-Term Release Branches
- Any release branch which has a name ending with a nonspecific version string, MUST be referred to as a "long-term release branch". For example, "release-2.11" is a long-term release branch, while "release-2.11.4" is a short-term release branch.
- Use of long-term release branches are OPTIONAL, and intended for work on versions which are not currently part of the main branch. Typically this is useful when you need to create a new maintenance release for an older version.
- A long-term release branch MUST have a name with a nonspecific version number. For example, a long-term release branch for creating new 2.9.x releases MUST be named "release-2.9", or "release-2" for all 2.x.x releases when main has moved to 3.x.x.
- Long-term release branches for maintenance releases of older versions MUST be created from the relevant release tag. For example, if the main branch is on version 2.11.4 and there is a security fix for all 2.9.x releases, the latest of which is "2.9.7". Create a new branch called "release-2.9" from the "2.9.7" release tag. The security fix release will then end up being version "2.9.8". Similarly, if main is on 3.x.x and you need to maintain the entire 2.x.x line, create a "release-2" branch from the latest 2.x.x release tag.
- To create a new release from a long-term release branch, you MUST follow the same process as a release from the main branch, except the long-term release branch takes the place of the main branch.
- A long-term release branch SHOULD be treated with the same respect as the main branch. It is effectively the main branch for the release series in question. Meaning it MUST always be in a non-broken state, MUST NOT be force pushed to, etc.
- Bug Fixes & Rollback
- You MUST NOT under any circumstances force push to the main branch or to long-term release branches.
- If a change branch which has been merged into the main branch is found to have a bug in it, the bugfix work MUST be done as a new separate change branch. This new change branch MUST follow the same workflow as any other change branch.
- If a change branch is wrongfully merged into main, or for any other reason the merge must be undone, you MUST undo the merge by reverting the merge commit itself. Effectively creating a new commit that reverses all the relevant changes.